Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ControlHOC ref for redux container widgets #812

Merged
merged 1 commit into from
Nov 12, 2017
Merged

fix ControlHOC ref for redux container widgets #812

merged 1 commit into from
Nov 12, 2017

Conversation

erquhart
Copy link
Contributor

@erquhart erquhart commented Nov 12, 2017 •
edited
Loading

If a widget uses connect to receive state updates from the store, ControlHOC can no longer get the control instance ref. This fix checks for this case and uses a connect option to obtain the wrapped control ref.

@erquhart
fix ControlHOC ref for redux container widgets
eb8a421 
If a widget uses `connect` to receive state updates from the store,
`ControlHOC` can no longer get the control instance ref. This fix
checks for this case and uses a connect option to obtain the wrapped
control ref.
@erquhart erquhart merged commit a4ff229 into master Nov 12, 2017
@erquhart erquhart deleted the fix-relation-widget-update branch November 12, 2017 02:42
@eliwilliamson
Copy link

eliwilliamson commented Nov 14, 2017 •
edited
Loading

@erquhart are you sure this is fixed? it seems to persist for me in 0.7.3. - still getting the following error:

ControlHOC.js:110 Uncaught TypeError: r.wrappedControlValid is not a function
    at t.r.validateWrappedControl (ControlHOC.js:110)
    at Object.r.validate [as sidebarlinks] (ControlHOC.js:71)
    at ControlPane.js:22
    at Me.__iterate (immutable.js:2206)
    at Me.forEach (immutable.js:4381)
    at t.o.validate (ControlPane.js:20)
    at r.handleOnPersist (EntryEditor.js:32)
    at Object.g (react-dom.production.min.js:36)
    at Object.invokeGuardedCallback (react-dom.production.min.js:35)
    at Object.invokeGuardedCallbackAndCatchFirstError (react-dom.production.min.js:35)

@erquhart
Copy link
Contributor Author

@eliwilliamson just seeing this - can you provide repro steps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erquhart @eliwilliamson